Skip to content

Clean up the duplicate volume (after failed migration) when the destination managed volume creation failed#4730

Merged
yadvr merged 1 commit intoapache:masterfrom
shapeblue:cs-cleanup-duplicate-volume-after-failed-migration
Mar 3, 2021
Merged

Clean up the duplicate volume (after failed migration) when the destination managed volume creation failed#4730
yadvr merged 1 commit intoapache:masterfrom
shapeblue:cs-cleanup-duplicate-volume-after-failed-migration

Conversation

@sureshanaparti
Copy link
Contributor

@sureshanaparti sureshanaparti commented Feb 25, 2021

Description

Duplicated volumes after failed migration in Allocated state

Fix: Clean up the duplicate volume when the destination managed volume creation failed on migrate volume operation

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Manually tested the fix with failed migration, confirmed that the duplicate volume (in Allocated state) is cleaned up.

@borisstoyanov
Copy link
Contributor

borisstoyanov commented Feb 25, 2021

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Feb 25, 2021

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Feb 25, 2021

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2827

@borisstoyanov
Copy link
Contributor

borisstoyanov commented Feb 25, 2021

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Feb 25, 2021

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

borisstoyanov
borisstoyanov approved these changes Feb 25, 2021
View reviewed changes
Copy link
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Manually verified, needs to see smoketests results.

@yadvr yadvr added this to the 4.16.0.0 milestone Feb 25, 2021
@yadvr
Copy link
Member

yadvr commented Feb 26, 2021

Some issue with smoketest (many failures, taking more than 10hrs), rekicking
@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Feb 26, 2021

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Feb 26, 2021

Trillian test result (tid-3620)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34674 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4730-t3620-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_01_migrate_VM_and_root_volume Error 76.72 test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks Error 51.43 test_vm_life_cycle.py

@yadvr yadvr merged commit 45e77dd into apache:master Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@borisstoyanov borisstoyanov borisstoyanov approved these changes

Assignees

No one assigned

Labels

component:migration type:bug

Projects

None yet

Milestone

4.16.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@sureshanaparti @borisstoyanov @blueorangutan @yadvr @nvazquez